AreEqual/AreNotEqual XML documentation is wrong

[cremor]

Many of the AreEqual/AreNotEqual overloads contain this text in their XML documentation:

Different numeric types are treated as unequal even if the logical values are equal. 42L is not equal to 42.

This is wrong.

To see this, run the following tests. Both will have results that do not match the expectation from the XML documentation.

[TestMethod]
public void ShouldFailAccordingToDocumentation()
{
    Assert.AreEqual(42L, 42);
}

[TestMethod]
public void ShouldPassAccordingToDocumentation()
{
    Assert.AreNotEqual(42L, 42);
}

AB#1726907

[Evangelink]

Hi @cremor,

You are absolutely right!

I just had a look and it doesn't seem to be a regression and all versions always worked as-is. I think the first implementation was containing only Assert.AreEqual(object, object) in which case this mention makes sense but as far as I can see all released versions of MSTest since v1 have other overloads like (long, long) which are used in the example you described and in this case, because of the implicit cast, the two values are now long and so are equal.

Given that and no-one ever complained about this logical equality rather than "type" equality, I would simply update the doc.

Is it something you would be willing to contribute or shall we do it on our side?

[cremor]

Given that and no-one ever complained about this logical equality rather than "type" equality, I would simply update the doc.

👍

Is it something you would be willing to contribute or shall we do it on our side?

I don't think that I'll have time for this in the near future, sorry.

[Evangelink]

No worries! Thanks for taking the time to reply! @engyebrahim, I am adding that to your backlog.