Ensure assertions do not fail with FormatException #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the assertion message construction order to ensure user message is built first (user message could fail with FormatException) and then include this user message in our messages. This switch of order ensure we will never throw FormatException because our built message becomes an invalid format composite.
|
@KalleOlaviNiemitalo This PR should fix all remaining possible FormatException we could have been generating, in case you want to review it too. Description explains the high level algorithm used. |
Haplois
previously approved these changes
Jun 9, 2022
Evangelink
commented
Jun 9, 2022
Haplois
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the assertion message construction order to ensure user message is built first (user message could fail with FormatException) and then include this user message in our messages. This switch of order ensure we will never throw FormatException because our built message becomes an invalid format composite.
Fixes dotnet/sdk#25373