Better messages for XXXInitialize and XXXCleanup #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same informative message for all XXXInitialize and XXXCleanup methods whatever the kind of exception. We used to have a simpler handling for Assert exceptions that was removing the information about the method throwing the exception.
Haplois
approved these changes
Jul 11, 2022
Evangelink
commented
Jul 11, 2022
There was a problem hiding this comment.
DAMN! I forgot to publish my comments...
@Haplois Please review them, I will do a follow-up PR if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the same informative message for all XXXInitialize and XXXCleanup methods whatever the kind of exception. We used to have a simpler handling for Assert exceptions that was removing the information about the method throwing the exception.
Related issue
Fixes #1142 and fixes AB#1543904