Improve assembly versions and available metadata #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
commented
Sep 7, 2022
Evangelink
commented
Sep 7, 2022
| <AssemblyVersion>$(MajorVersion).0.0</AssemblyVersion> | ||
| <BuildVersion Condition=" '$(BuildVersion)' == '' ">$(MajorVersion).$(TFBuildNumber)</BuildVersion> | ||
| <AssemblyVersion>$(LegacyMajorVersion).$(LegacyMinorVersion).0.0</AssemblyVersion> | ||
| <BuildVersion Condition=" '$(BuildVersion)' == '' ">$(LegacyMajorVersion).$(LegacyMinorVersion).$(TFBuildNumber)</BuildVersion> | ||
| <FileVersion Condition=" '$(FileVersion)' == '' ">$(BuildVersion)</FileVersion> |
There was a problem hiding this comment.
I haven't touched the FileVersion so far, as discussed we need to make tests to see if this can be safely updated.
Haplois
previously approved these changes
Sep 7, 2022
| @@ -11,7 +11,6 @@ | |||
| <PropertyGroup> | |||
| <BranchName Condition=" '$(BranchName)' == '' ">BRANCHNAME</BranchName> | |||
| <CommitHash Condition=" '$(CommitHash)' == '' ">COMMITHASH</CommitHash> | |||
| <CommitId>$(CommitHash.SubString(0, 8))</CommitId> | |||
There was a problem hiding this comment.
No one liked my short hashes :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1051
Example when running locally:
Obviously, version number will be the correct ones when coming from CI.