-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve assembly versions and available metadata #1231
Conversation
<AssemblyVersion>$(MajorVersion).0.0</AssemblyVersion> | ||
<BuildVersion Condition=" '$(BuildVersion)' == '' ">$(MajorVersion).$(TFBuildNumber)</BuildVersion> | ||
<AssemblyVersion>$(LegacyMajorVersion).$(LegacyMinorVersion).0.0</AssemblyVersion> | ||
<BuildVersion Condition=" '$(BuildVersion)' == '' ">$(LegacyMajorVersion).$(LegacyMinorVersion).$(TFBuildNumber)</BuildVersion> | ||
<FileVersion Condition=" '$(FileVersion)' == '' ">$(BuildVersion)</FileVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't touched the FileVersion
so far, as discussed we need to make tests to see if this can be safely updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -11,7 +11,6 @@ | |||
<PropertyGroup> | |||
<BranchName Condition=" '$(BranchName)' == '' ">BRANCHNAME</BranchName> | |||
<CommitHash Condition=" '$(CommitHash)' == '' ">COMMITHASH</CommitHash> | |||
<CommitId>$(CommitHash.SubString(0, 8))</CommitId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No one liked my short hashes :(
Fixes #1051
Example when running locally:
Obviously, version number will be the correct ones when coming from CI.