-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Assert.IsInstanceOfType<T> #1241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase on main.
# Conflicts: # src/TestFramework/MSTest.Core/Assertions/Assert.IsInstanceOfType.cs # src/TestFramework/MSTest.Core/Assertions/Assert.cs # test/UnitTests/MSTest.Core.Unit.Tests/Assertions/AssertTests.AreEqualTests.cs # test/UnitTests/MSTest.Core.Unit.Tests/Assertions/AssertTests.IsInstanceOfTypeTests.cs
src/TestFramework/MSTest.Core/Assertions/Assert.IsInstanceOfType.cs
Outdated
Show resolved
Hide resolved
src/TestFramework/MSTest.Core/Assertions/Assert.IsInstanceOfType.cs
Outdated
Show resolved
Hide resolved
src/TestFramework/MSTest.Core/Assertions/Assert.IsInstanceOfType.cs
Outdated
Show resolved
Hide resolved
src/TestFramework/MSTest.Core/Assertions/Assert.IsInstanceOfType.cs
Outdated
Show resolved
Hide resolved
src/TestFramework/MSTest.Core/Assertions/Assert.IsInstanceOfType.cs
Outdated
Show resolved
Hide resolved
test/UnitTests/MSTest.Core.Unit.Tests/Assertions/AssertTests.AreEqualTests.cs
Outdated
Show resolved
Hide resolved
test/UnitTests/MSTest.Core.Unit.Tests/Assertions/AssertTests.IsInstanceOfTypeTests.cs
Outdated
Show resolved
Hide resolved
test/UnitTests/MSTest.Core.Unit.Tests/Assertions/AssertTests.IsInstanceOfTypeTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss offline a couple of things:
- Shall we deprecate the old API in favor of this one?
- Shall we use the same pattern as for other APIs (i.e. not using
CallerArgumentExpressionAttribute
) and do the update globally in v3? Or shall we add new principle directly now knowing we would have 2 kinds of API (inconsistent behavior for users).
test/UnitTests/MSTest.Core.Unit.Tests/Assertions/AssertTests.IsInstanceOfTypeTests.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # src/TestFramework/MSTest.Core/Assertions/Assert.IsInstanceOfType.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Globally LGTM! Could you please fix the 2 broken tests.
Please update the description to mention the ticket this PR relates to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final nit.
Fixes: #413