Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert MSTest.CoreAdapter.Unit.Tests to use new test framework #1245

Merged
merged 16 commits into from
Sep 14, 2022
Merged

Convert MSTest.CoreAdapter.Unit.Tests to use new test framework #1245

merged 16 commits into from
Sep 14, 2022

Conversation

Evangelink
Copy link
Member

No description provided.

Evangelink
Evangelink commented Sep 13, 2022
View reviewed changes
test/TestFramework.ForTestingMSTest/TestContainer.cs Outdated Show resolved Hide resolved
test/TestFramework.ForTestingMSTest/TestContainer.cs Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/AssemblyEnumeratorTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/AssemblyEnumeratorTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/AssemblyEnumeratorTests.cs Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/MSTestDiscovererTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/ObjectModel/UnitTestElementTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/ObjectModel/UnitTestElementTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/ObjectModel/UnitTestElementTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/RunConfigurationSettingsTests.cs Outdated Show resolved Hide resolved
Evangelink
Evangelink commented Sep 13, 2022
View reviewed changes
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/TypeEnumeratorTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/TypeEnumeratorTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/TypeEnumeratorTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/TypeEnumeratorTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/TypeEnumeratorTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestExecutionManagerTests.cs Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestExecutionManagerTests.cs Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestExecutionManagerTests.cs Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/TypeEnumeratorTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/TypeEnumeratorTests.cs Outdated Show resolved Hide resolved
@Evangelink Evangelink changed the title Convert test projects to use new test framework Convert MSTest.CoreAdapter.Unit.Tests to use new test framework Sep 14, 2022
Evangelink
Evangelink commented Sep 14, 2022
View reviewed changes
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/AssemblyEnumeratorTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/AssemblyEnumeratorTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/AssemblyEnumeratorTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/AssemblyEnumeratorTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/AssemblyEnumeratorTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Discovery/TypeEnumeratorTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/ObjectModel/UnitTestElementTests.cs Outdated Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/ObjectModel/UnitTestElementTests.cs Outdated Show resolved Hide resolved
Evangelink
Evangelink commented Sep 14, 2022
View reviewed changes
Copy link
Member Author

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there! Thank you for the effort on this hard PR!

test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Helpers/DictionaryHelperTests.cs Show resolved Hide resolved
test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Helpers/DictionaryHelperTests.cs Show resolved Hide resolved
@Evangelink Evangelink marked this pull request as ready for review September 14, 2022 15:33
Evangelink
Evangelink commented Sep 14, 2022
View reviewed changes
Copy link
Member Author

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @engyebrahim :shipit: ㊗️ 🎊

@Evangelink Evangelink merged commit d520934 into microsoft:main Sep 14, 2022
@Evangelink Evangelink deleted the convert-test-projects branch September 14, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engyebrahim engyebrahim engyebrahim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Evangelink @engyebrahim