Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert smoke.e2e.tests and DiscoveryAndExecutionTests to use local test framework #1261

Merged
merged 16 commits into from
Sep 26, 2022
Merged

Convert smoke.e2e.tests and DiscoveryAndExecutionTests to use local test framework #1261

merged 16 commits into from
Sep 26, 2022

Conversation

engyebrahim
Copy link
Member

No description provided.

Evangelink
Evangelink previously approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks but overall LGTM! Thank you for taking the time to update the method finding test containers 👍

test/E2ETests/Smoke.E2E.Tests/TestDataSourceTests.cs Outdated Show resolved Hide resolved
test/TestFramework.ForTestingMSTest/AdapterToTestPlatform.cs Outdated Show resolved Hide resolved
test/TestFramework.ForTestingMSTest/AdapterToTestPlatform.cs Outdated Show resolved Hide resolved
test/TestFramework.ForTestingMSTest/AdapterToTestPlatform.cs Outdated Show resolved Hide resolved
@Evangelink Evangelink changed the title Convert smoke.e2e.tests Convert smoke.e2e.tests to use local test framework Sep 22, 2022
@Evangelink Evangelink enabled auto-merge (squash) September 22, 2022 09:48
Evangelink
Evangelink previously approved these changes Sep 26, 2022
View reviewed changes
Evangelink
Evangelink previously approved these changes Sep 26, 2022
View reviewed changes
@engyebrahim
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Evangelink Evangelink changed the title Convert smoke.e2e.tests to use local test framework Convert smoke.e2e.tests and DiscoveryAndExecutionTests to use local test framework Sep 26, 2022
@Evangelink
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Evangelink Evangelink merged commit 63afc7a into microsoft:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@engyebrahim @Evangelink