Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove class/assembly initialization messages from logs. #1339

Conversation

engyebrahim
Copy link
Member

Fix: #1328

@engyebrahim engyebrahim marked this pull request as ready for review October 14, 2022 10:07
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title is a little long and could probably be simplified to Remove class/assembly initialization messages from logs.

I see that the PR is marked as fixing the ticket which means that we will be left with no ticket tracking the fact that we ultimately want to have assembly/class initialize/cleanup messages to be printed somehow/somewhere.

src/Adapter/MSTest.TestAdapter/Execution/TestClassInfo.cs Outdated Show resolved Hide resolved
@engyebrahim engyebrahim changed the title Fix different behavior between class/assembly cleanup and inti by removing init logs from results Remove class/assembly initialization messages from logs. Oct 14, 2022
@Evangelink Evangelink enabled auto-merge (squash) October 14, 2022 13:12
@Evangelink Evangelink merged commit bbdabb3 into microsoft:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different behavior with TestContext.WriteLine() in [ClassInitialize] and [ClassCleanup] function.
2 participants