-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add class/assembly cleanup/init messages to first/last test #1390
Add class/assembly cleanup/init messages to first/last test #1390
Conversation
test/UnitTests/MSTestAdapter.UnitTests/Execution/TestExecutionManagerTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Could you please review the test caseInheritClassWithCleanupInheritanceBehaviorNone_ParentTestMethod
where the order of calls changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is something fishy with the implementation (maybe how you find the test to attach cleanup results to) because it seems that the ClassCleanup.InheritanceBehaviorBeforeEachDerivedClass
messages are not attached to the correct test.
@@ -183,14 +183,14 @@ internal TestResult ToTestResult(TestCase testCase, DateTimeOffset startTime, Da | |||
|
|||
if (!StringEx.IsNullOrEmpty(DebugTrace)) | |||
{ | |||
string debugTraceMessagesInStdOut = string.Format(CultureInfo.InvariantCulture, "\n\n{0}\n{1}", Resource.DebugTraceBanner, DebugTrace); | |||
string debugTraceMessagesInStdOut = string.Format(CultureInfo.CurrentCulture, "{2}{2}{0}{2}{1}", Resource.DebugTraceBanner, DebugTrace, Environment.NewLine); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use OS line return to avoid mixing line return kinds.
fix: #1340