Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init and cleanup timeout #2570

Merged
merged 47 commits into from
Mar 27, 2024
Merged

Init and cleanup timeout #2570

merged 47 commits into from
Mar 27, 2024

Conversation

engyebrahim
Copy link
Member

@engyebrahim engyebrahim commented Mar 15, 2024 •
edited
Loading

fix: #2414

@engyebrahim engyebrahim marked this pull request as draft March 15, 2024 08:35
@engyebrahim engyebrahim changed the title Assembly cleanup timeout Init and cleanup timeout Mar 22, 2024
MarcoRossignoli
MarcoRossignoli reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some question/nit, the most important is that ref that now can be null that scare me a bit but generally good

@engyebrahim engyebrahim enabled auto-merge (squash) March 27, 2024 01:22
@engyebrahim engyebrahim merged commit c089998 into main Mar 27, 2024
6 checks passed
@engyebrahim engyebrahim deleted the Enji/timeout branch March 27, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink left review comments

@MarcoRossignoli MarcoRossignoli MarcoRossignoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timeout support for ClassCleanup, AssemblyCleanup, TestCleanup and TestInitalize
3 participants
@engyebrahim @MarcoRossignoli @Evangelink