Update NativeAOT runner example #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Evangelink
reviewed
Mar 29, 2024
| <!-- MSTest early access packages. See: https://aka.ms/mstest/preview uncomment this line --> | ||
| <!-- <add key="test-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/test-tools/nuget/v3/index.json" /> --> | ||
| <clear /> | ||
| <add key="nuget" value="https://api.nuget.org/v3/index.json" /> |
There was a problem hiding this comment.
We should not do that, this is causing security alerts. We should instead use the dotnet-public feed. I think just dropping this nuget.config to use the one from parent folder would be enough.
|
Using that feed made it fail the restore. Do you have a build that has the compliance errors please? As long as there is a single public feed preceeded by <clear> that should be okay.
Odesláno z aplikace Outlook pro iOS<https://aka.ms/o0ukef>
________________________________
Od: Amaury Levé ***@***.***>
Odesláno: Friday, March 29, 2024 9:22:33 AM
Komu: microsoft/testfx ***@***.***>
Kopie: Jakub Jares ***@***.***>; State change ***@***.***>
Předmět: Re: [microsoft/testfx] Update NativeAOT runner example (PR #2634)
@Evangelink commented on this pull request.
________________________________
In samples/mstest-runner/NativeAotRunner/nuget.config<#2634 (comment)>:
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<configuration>
<packageSources>
- <!-- MSTest early access packages. See: https://aka.ms/mstest/preview uncomment this line -->
- <!-- <add key="test-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/test-tools/nuget/v3/index.json" /> -->
+ <clear />
+ <add key="nuget" value="https://api.nuget.org/v3/index.json" />
We should not do that, this is causing security alerts. We should instead use the dotnet-public feed. I think just dropping this nuget.config to use the one from parent folder would be enough.
—
Reply to this email directly, view it on GitHub<#2634 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABLYLYIQVX4MFFXICOH2ERTY2UJDTAVCNFSM6AAAAABFKZE4XGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRYGA4TCNZSHE>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Tested and I can repro. The error is coming from the fact that these packages were not mirrored, I have triggered a mirror request so we should be able to drop the extra
It wasn't a CG but it was a new security alert. I am not sure how to find back the closed/fixed alerts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.