-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NativeAOT runner example #2634
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
<!-- MSTest early access packages. See: https://aka.ms/mstest/preview uncomment this line --> | ||
<!-- <add key="test-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/test-tools/nuget/v3/index.json" /> --> | ||
<clear /> | ||
<add key="nuget" value="https://api.nuget.org/v3/index.json" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not do that, this is causing security alerts. We should instead use the dotnet-public
feed. I think just dropping this nuget.config
to use the one from parent folder would be enough.
Using that feed made it fail the restore. Do you have a build that has the compliance errors please? As long as there is a single public feed preceeded by <clear> that should be okay.
Odesláno z aplikace Outlook pro iOS<https://aka.ms/o0ukef>
________________________________
Od: Amaury Levé ***@***.***>
Odesláno: Friday, March 29, 2024 9:22:33 AM
Komu: microsoft/testfx ***@***.***>
Kopie: Jakub Jares ***@***.***>; State change ***@***.***>
Předmět: Re: [microsoft/testfx] Update NativeAOT runner example (PR #2634)
@Evangelink commented on this pull request.
________________________________
In samples/mstest-runner/NativeAotRunner/nuget.config<#2634 (comment)>:
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<configuration>
<packageSources>
- <!-- MSTest early access packages. See: https://aka.ms/mstest/preview uncomment this line -->
- <!-- <add key="test-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/test-tools/nuget/v3/index.json" /> -->
+ <clear />
+ <add key="nuget" value="https://api.nuget.org/v3/index.json" />
We should not do that, this is causing security alerts. We should instead use the dotnet-public feed. I think just dropping this nuget.config to use the one from parent folder would be enough.
—
Reply to this email directly, view it on GitHub<#2634 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABLYLYIQVX4MFFXICOH2ERTY2UJDTAVCNFSM6AAAAABFKZE4XGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRYGA4TCNZSHE>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Tested and I can repro. The error is coming from the fact that these packages were not mirrored, I have triggered a mirror request so we should be able to drop the extra
It wasn't a CG but it was a new security alert. I am not sure how to find back the closed/fixed alerts. |
No description provided.