perf: reduce allocations and calls to ToArray #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -272,7 +272,7 @@ protected IEnumerable<string> Deploy(IList<DeploymentItem> deploymentItems, stri | |||
| /// <param name="isDirectory">Is this a directory.</param> | |||
| /// <returns>Paths to items to deploy.</returns> | |||
| [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1031:DoNotCatchGeneralExceptionTypes", Justification = "Requirement is to handle all kinds of user exceptions and message appropriately.")] | |||
| protected string[]? GetFullPathToFilesCorrespondingToDeploymentItem(DeploymentItem deploymentItem, string testSource, string resultsDirectory, IList<string> warnings, out bool isDirectory) | |||
| protected List<string>? GetFullPathToFilesCorrespondingToDeploymentItem(DeploymentItem deploymentItem, string testSource, string resultsDirectory, IList<string> warnings, out bool isDirectory) | |||
There was a problem hiding this comment.
IList/IReadOnlyList?
There was a problem hiding this comment.
This is only internal/private stuff so I prefer to always be as specific as possible.
| #endif | ||
| } | ||
|
|
||
| #if NETFRAMEWORK | ||
| internal static object[] GetCustomAttributes(Assembly assembly, Type type) | ||
| internal static List<Attribute> GetCustomAttributes(Assembly assembly, Type type) |
MarcoRossignoli
approved these changes
Apr 23, 2024
|
I get the intent here, for stuff like ToArray().Length == 1, but for example the change in src/Adapter/MSTest.TestAdapter/Execution/TypeCache.cs makes the api pretty jagged, where some parts return ICollection and some return IEnumerable, just because some items need filtering and some don't. In most cases we will enumerate the collection eventually, so is there that much work that we are saving by not putting it in array or some other ICollection? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.