Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use some StringSyntax Xml #2974

Merged
merged 4 commits into from
May 29, 2024
Merged

use some StringSyntax Xml #2974

merged 4 commits into from
May 29, 2024

Conversation

SimonCropp
Copy link
Contributor

No description provided.

Evangelink
Evangelink reviewed May 27, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will probably need to enrich the polyfill file to add this new attribute.

@SimonCropp
Copy link
Contributor Author

thanks. will take a look at that

have u considered using some pre-packaged polyfills? eg https://github.com/SimonCropp/Polyfill ?

@Evangelink
Copy link
Member

have u considered using some pre-packaged polyfills? eg SimonCropp/Polyfill ?

Happy to set it up, but lets make sure it doesn't flow as dependency to our package.

@Evangelink
Copy link
Member

Hopefully with the rebase we should be good now.

@Evangelink Evangelink enabled auto-merge (squash) May 29, 2024 08:24
@Evangelink Evangelink merged commit fa12884 into microsoft:main May 29, 2024
6 checks passed
@SimonCropp SimonCropp deleted the use-some-StringSyntax-Xml branch May 29, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonCropp @Evangelink