Use polyfill package #3014
Merged
Use polyfill package #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
commented
May 28, 2024
| @@ -0,0 +1,114 @@ | |||
| #nullable enable | |||
There was a problem hiding this comment.
Not sure why but the analyzer suddenly triggered issues on the project although the configuration to not raise when the file doesn't exist is setup.
|
|
||
| // We usually do not want to suppress issues through GlobalSuppressions file but in this case we have to do it because | ||
| // we are not able to suppress the issue differently. | ||
| [assembly: SuppressMessage("ApiDesign", "RS0030:Do not use banned APIs", Justification = "Source-generated file that cannot match analyzers requirements", Scope = "member", Target = "~M:System.Reflection.NullabilityInfoContext.CheckParameterMetadataType(System.Reflection.ParameterInfo,System.Reflection.NullabilityInfo)")] |
There was a problem hiding this comment.
We use a custom class for Debug.Assert (RoslynDebug) and string.IsNullOrXXX (RoslynString) that add annotation to the APIs. We are using banned apis to ensure they are used and it's triggering on the generated class although the generated code comment is setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @SimonCropp