Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve display name for string and char #3082

Merged
merged 20 commits into from
Jun 10, 2024
Merged

Improve display name for string and char #3082

merged 20 commits into from
Jun 10, 2024

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Jun 10, 2024

Fixes #1647

@MichelZ MichelZ mentioned this pull request Jun 10, 2024
Closed
@MichelZ MichelZ changed the title Mize/1647 datarow null empty Improve display name for string and char Jun 10, 2024
Evangelink
Evangelink approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for the nice contribution @MichelZ :shipit:

@MichelZ MichelZ marked this pull request as ready for review June 10, 2024 15:56
@Evangelink Evangelink merged commit 3937b03 into microsoft:main Jun 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
Area: Parameterized tests Type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataRow: Nulls and empty string are displayed as no data in display name
2 participants
@MichelZ @Evangelink