Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSTEST0030: Type contaning [TestMethod] must be a [TestClass] #3199

Merged
merged 17 commits into from
Jul 2, 2024
Merged

MSTEST0030: Type contaning [TestMethod] must be a [TestClass] #3199

merged 17 commits into from
Jul 2, 2024

Conversation

engyebrahim
Copy link
Member

fix: #2862

@engyebrahim engyebrahim marked this pull request as ready for review July 2, 2024 08:56
nohwnd
nohwnd reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@nohwnd nohwnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, this analyzer will be so helpful :)

test/UnitTests/MSTest.Analyzers.UnitTests/TypeContainingTestMethodShouldBeATestClassAnalyzer.cs Show resolved Hide resolved
Evangelink
Evangelink reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nohwnd Can you please review the messages

src/Analyzers/MSTest.Analyzers/AnalyzerReleases.Unshipped.md Outdated Show resolved Hide resolved
src/Analyzers/MSTest.Analyzers/TypeContainingTestMethodShouldBeATestClassAnalyzer.cs Outdated Show resolved Hide resolved
src/Analyzers/MSTest.Analyzers/TypeContainingTestMethodShouldBeATestClassAnalyzer.cs Show resolved Hide resolved
src/Analyzers/MSTest.Analyzers/TypeContainingTestMethodShouldBeATestClassAnalyzer.cs Show resolved Hide resolved
src/Analyzers/MSTest.Analyzers/Resources.resx Outdated Show resolved Hide resolved
src/Analyzers/MSTest.Analyzers/Resources.resx Outdated Show resolved Hide resolved
src/Analyzers/MSTest.Analyzers/Resources.resx Outdated Show resolved Hide resolved
test/UnitTests/MSTest.Analyzers.UnitTests/TypeContainingTestMethodShouldBeATestClassAnalyzer.cs Show resolved Hide resolved
@engyebrahim engyebrahim mentioned this pull request Jul 2, 2024
Merged
@Evangelink Evangelink enabled auto-merge (squash) July 2, 2024 14:12
@Evangelink Evangelink merged commit 8a5cde9 into main Jul 2, 2024
7 checks passed
@Evangelink Evangelink deleted the Enji/testmethod-without-testclass branch July 2, 2024 14:35
@nohwnd nohwnd mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nohwnd nohwnd nohwnd left review comments

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MSTESTXXXX: Type contaning [TestMethod] must be a [TestClass]
3 participants
@engyebrahim @nohwnd @Evangelink