-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running parallelized tests in STA thread #3213
Conversation
src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcoRossignoli could you please review too?!
src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could try to have transparent code, this will help also in future when we will move to different "thread pool". Today we're wasting n threads because we're using long running. I think we could move to thread pool one and avoid context-switch, memory consumption and the time to create the threads self.
src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs
Outdated
Show resolved
Hide resolved
Merging as-is for now, we can refactor later if we want. |
fix: #3208