Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix running parallelized tests in STA thread #3213

Merged
merged 14 commits into from
Jul 8, 2024
Merged

Fix running parallelized tests in STA thread #3213

merged 14 commits into from
Jul 8, 2024

Conversation

engyebrahim
Copy link
Member

fix: #3208

@engyebrahim engyebrahim marked this pull request as ready for review July 8, 2024 10:26
Evangelink
Evangelink reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoRossignoli could you please review too?!

src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Outdated Show resolved Hide resolved
src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Outdated Show resolved Hide resolved
src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Outdated Show resolved Hide resolved
Evangelink
Evangelink previously approved these changes Jul 8, 2024
View reviewed changes
@Evangelink Evangelink changed the title ExecutionThreadAppartment.STA in runsettings doesn't work when tests are parallelized Fix running parallelized tests in STA thread Jul 8, 2024
@MarcoRossignoli MarcoRossignoli enabled auto-merge (squash) July 8, 2024 12:01
MarcoRossignoli
MarcoRossignoli requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could try to have transparent code, this will help also in future when we will move to different "thread pool". Today we're wasting n threads because we're using long running. I think we could move to thread pool one and avoid context-switch, memory consumption and the time to create the threads self.

@Evangelink Evangelink disabled auto-merge July 8, 2024 19:19
@Evangelink
Copy link
Member

Merging as-is for now, we can refactor later if we want.

@Evangelink Evangelink merged commit 0f4069f into main Jul 8, 2024
6 checks passed
@Evangelink Evangelink deleted the Enji/parralel branch July 8, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

@MarcoRossignoli MarcoRossignoli Awaiting requested review from MarcoRossignoli

Assignees

@engyebrahim engyebrahim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExecutionThreadAppartment.STA in runsettings doesn't work when tests are parallelized
3 participants
@engyebrahim @Evangelink @MarcoRossignoli