Workaround the UWP release mode issue with DataRow data #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
commented
Jul 10, 2024
| // See https://github.com/microsoft/testfx/issues/3071 | ||
| if (argumentsLengthOrZero == 1 | ||
| && argumentsLengthOrZero < methodParametersLengthOrZero | ||
| && arguments![0] is object[] args) |
There was a problem hiding this comment.
We could be even more restrictive and only unwrap if args.Length == methodParametersLengthOrZero, WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a bug in UWP release mode when ".NET Native tool chain" is enabled causing the data to be wrapped in an
object[]. While waiting for a proper fix, we are adding a logic to unwrap the data.Manually tested.
Fixes #3071