Skipped tests count as not run #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,7 +15,6 @@ internal static class TestNodePropertiesCategories | |||
| public static Type[] WellKnownTestNodeTestRunOutcomeProperties { get; } = | |||
| [ | |||
| typeof(PassedTestNodeStateProperty), | |||
| typeof(SkippedTestNodeStateProperty), | |||
There was a problem hiding this comment.
this could break some extension I suppose, is it needed?
There was a problem hiding this comment.
Type is internal so it should be fine. Also, yes the array is used directly to count test that run. As we said, skipped should not be considered as run.
There was a problem hiding this comment.
It's internal but used around by built-in extensions too, I would take a look around before and in case duplicate it
There was a problem hiding this comment.
Not used anywhere else in this repo (all OSS extensions: https://github.com/search?q=repo%3Amicrosoft%2Ftestfx%20WellKnownTestNodeTestRunOutcomeProperties%20&type=code) but indeed retry is impacted
# Conflicts: # test/UnitTests/Microsoft.Testing.Platform.UnitTests/Program.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the logic to consider skipped tests as not run:
Fixes #3216