Setting MapNotRunnableToFailed to true by default #610
+25
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhsarab
reviewed
Apr 29, 2019
| @@ -292,11 +292,12 @@ public void UniTestHelperToTestOutcomeForUnitTestOutcomeErrorShouldReturnTestOut | |||
| } | |||
|
|
|||
| [TestMethod] | |||
| public void UniTestHelperToTestOutcomeForUnitTestOutcomeNotRunnableShouldReturnTestOutcomeNoneWhenNotSpecified() | |||
| public void UniTestHelperToTestOutcomeForUnitTestOutcomeNotRunnableShouldReturnTestOutcomeNoneWhenSpecified() | |||
There was a problem hiding this comment.
Please change the name for this test.
Should start with UnitTestResults* and just specified, does not make sense. Make sure you call out it's set to false.
There was a problem hiding this comment.
Similar for the test below.
|
I want us to be careful with this change, please make sure it is available as part of the beta release |
singhsarab
approved these changes
Apr 29, 2019
jayaranigarg
approved these changes
Apr 29, 2019
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting MSTest settings option MapNotRunnableToFailed to true by default. This will lead all tests that cannot be executed to result in failed outcome.