Configuring child domain's appbase to be test source location #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var sourceSettings = sourceSettingsProvider.GetSettings(source); | ||
| var parallelWorkers = sourceSettings.Workers; |
There was a problem hiding this comment.
Ensure that default values for sourceSettings.Workers, & Scope is set appropriately in case we fail to create instance of "TestAssemblySettingsProvider"
singhsarab
reviewed
Nov 26, 2019
src/Adapter/MSTest.CoreAdapter/Execution/TestExecutionManager.cs
Outdated
Show resolved
Hide resolved
singhsarab
reviewed
Nov 26, 2019
src/Adapter/MSTest.CoreAdapter/Execution/TestExecutionManager.cs
Outdated
Show resolved
Hide resolved
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this fix, we are setting child's appdomain to point to the test source location so that the dependencies gets picked up from the the test source location itself or we honor the relative path specified in app.config file.
In scenario where we have multiple projects in a solution each using different versions of adapter, currently we run the projects with highest version of adapter referenced in that solution irrespective of the version a project references. After this fix, there will be a behavior change where each project will be run using the exact adapter version that particular project references and not the highest one in that solution.