Added StringComparison to StringAssert Contains(), EndsWith() & StartsWith() #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeroMaxPower
changed the title
304NotModified
suggested changes
Apr 20, 2020
|
@HeroMaxPower are you going to address the PR comments or should I? |
|
Yes please, i haven't had time in my personal life to look at these. 👍 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@304NotModified Would you review again please? I had to pass empty array to disambiguate the calls (before we passed null). The compiler will pass empty array for us, so we should not be doing anything wrong. Unless the user passed StringComparison as the actual first param, then they now would get different overload than before. But that is unlikely scenario. |
|
@304NotModified any updates? |
304NotModified
approved these changes
Sep 17, 2020
|
@nohwnd i think this is ready to be merged 👍 |
|
@Haplois could you review and merge please? |
Haplois
approved these changes
Sep 29, 2020
HeroMaxPower
deleted the
string-asserts-with-string-comparison-options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added StringComparison to StringAssert Contains, EndsWith & StartsWith
Added tests to test functionality
Added API comment on StringComparison Enum
Updated APIs to default to StringComparison.Ordinal
Probably needs API documentation updates if this gets merged.
Resolves #154