Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to treat class/assembly warnings as errors #717

Merged

Conversation

NGloreous
Copy link
Contributor

Assembly/Class cleanup errors mostly go unnoticed today (they get logged as a warning which for most automated CI systems means nobody sees the warning since it doesn't fail the test run). Even if the warning was surfaced, any output from these cleanups are discarded so it's harder to debug the issue.

There are two parts to this change:

  • Add a setting to treat assembly/class cleanup warnings as errors to cause the test run to fail
  • Log stdout & stderr captured during cleanup to help in debugging.

@nohwnd nohwnd added this to the 16.8.0 milestone Jun 11, 2020
@Haplois Haplois self-assigned this Sep 4, 2020
@Haplois Haplois merged commit e58ecb9 into microsoft:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants