WIP: Implement Class Cleanup Lifecycle selection #724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nohwnd
reviewed
Aug 6, 2021
src/TestFramework/MSTest.Core/Attributes/ClassCleanupSequencingAttribute.cs
Show resolved
Hide resolved
src/TestFramework/MSTest.Core/Attributes/ClassCleanupSequencingAttribute.cs
Show resolved
Hide resolved
| @@ -56,6 +56,13 @@ internal TestAssemblySettings GetSettings(string source) | |||
|
|
|||
| testAssemblySettings.CanParallelizeAssembly = !this.reflectHelper.IsDoNotParallelizeSet(testAssembly); | |||
|
|
|||
| var classCleanupSequencingAttribute = this.reflectHelper.GetClassCleanupAttribute(testAssembly); | |||
There was a problem hiding this comment.
Is this naming based on some existing settings we have? I think we should choose between Sequencing and Lifecycle if there is no existing example of this and in that case Lifecycle seems easier to grasp.
Or possibly ClassCleanupExecution?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm soliciting early feedback on a branch to introduce a lifecycle policy for the
ClassCleanupattribute. This allows a test author to set at the command line, assembly, or class level, whether a theClassCleanupshould happen at the end of a class, or at the end of the assembly.I've lightly tested this, and it seems to work as expected in my tests, though I am not confident in its robustness in its current form. Specifically, my current implementation relying on a dictionary of the strings of the full test names seems fragile to me, though I was unable to determine how to instead track via the guids on the completion side of the dictionary.
If this feature seems generally appeciated, I'd love guidance from those more familar with the MSTest codebase in how I might improve my implementation.
A part of any final submission I will surely include reverting the many changed build files - those were needed to build in my environment, and are not to be present in any final reviews.
Thank you.