-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BugFix: WorkItemAttribute not extracted #749
Conversation
I'd really appreciate this PR. |
Hello @Haplois! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM. Thank you for your contribution.
Thank you for your review! Is there any chance you could tell when a preview will be available? |
There is a back-compatibility issue in https://github.com/microsoft/vstest; after the fix is merged there, we can release a preview. Hopefully on this Friday, or mid next week at the latest. We're also continuously integrating into our daily feed. You can use that for now. The version should be "MSTest.TestAdapter 2.2.0-preview-20201209-01" after the build completes. |
The
TypeEnumerator
class returned anAttribute[]
, which cannot be casted to anWorkItemAttribute[]
. Even though the method signature specified anAttribute[]
, the mock was set up to return aWorkItemAttribute[]
array, which causes the test to pass but theas
conversion to fail at runtime.