Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TypesToLoadAttribute compatibility #753

Merged
2 commits merged into from
Dec 14, 2020

Conversation

Haplois
Copy link
Contributor

@Haplois Haplois commented Dec 14, 2020

TestFx updated to implement changes in microsoft/vstest#2674; this should fix the compatibility issue introduced in microsoft/vstest#2537 and #739.

    Removed TypesToLoadAttribute dependency from ObjectModel, now using an internal implementation.
@Haplois Haplois self-assigned this Dec 14, 2020
@ghost
Copy link

ghost commented Dec 14, 2020

Hello @Haplois!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 3 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit e189210 into microsoft:master Dec 14, 2020
Copy link

@shyamnamboodiripad shyamnamboodiripad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comments about naming

@Haplois Haplois deleted the fix/removed-types-to-load branch December 14, 2020 21:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants