Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge settings safely #771

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Feb 15, 2021

Merge session and source level settings safely. Linq.Concat will throw "key has already been added" exception when there are duplicates. This add a helper method that will merge the dictionaries safely.

@nohwnd nohwnd requested a review from Haplois February 15, 2021 12:13
@nohwnd nohwnd added the sprint label Feb 15, 2021
Copy link
Contributor

@Haplois Haplois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nohwnd nohwnd merged commit f55dc39 into microsoft:master Feb 15, 2021
This was referenced Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants