Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve vulnerabilities #401

Merged
merged 3 commits into from
Feb 18, 2022
Merged

Resolve vulnerabilities #401

merged 3 commits into from
Feb 18, 2022

Conversation

mr-dokara
Copy link
Contributor

@mr-dokara mr-dokara commented Feb 11, 2022 •
edited by DaniilShmelev
Loading

Updated dependencies:

  • mkdirp to 1.0.4 - after this update mkdirp function changed: now it uses a promise instead of a callback. Had to make some code changes to fix that.
  • shelljs to 0.8.5
  • validator to 13.7.0

List of commands tested locally:

  • login
  • workitem create
  • workitem query
  • workitem update
  • workitem show
  • build list
  • build queue
  • build show
  • build tasks create
  • build tasks upload
  • build tasks list
  • build tasks delete
  • extension create

Ivan Golubev and others added 3 commits February 11, 2022 15:10
Resolve vulnerabilities
4ef8288
@DaniilShmelev
fix updated mkdirp usage
6877137 
mkdirp major bump caused breaking changes, which broke some commands
@DaniilShmelev
fix shelljs types
68cba2c
@DaniilShmelev DaniilShmelev self-assigned this Feb 16, 2022
@DaniilShmelev DaniilShmelev requested a review from a team February 16, 2022 11:59
AndreyIvanov42
AndreyIvanov42 approved these changes Feb 17, 2022
View reviewed changes
Copy link

@AndreyIvanov42 AndreyIvanov42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, changes work fine

@DaniilShmelev DaniilShmelev merged commit 30ffb29 into master Feb 18, 2022
@max-zaytsev max-zaytsev deleted the users/golubev-ivan/resolve-vulnerabilities branch September 25, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenisRumyantsev DenisRumyantsev DenisRumyantsev approved these changes

@AndreyIvanov42 AndreyIvanov42 AndreyIvanov42 approved these changes

Assignees

@DaniilShmelev DaniilShmelev

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mr-dokara @DenisRumyantsev @AndreyIvanov42 @DaniilShmelev