Support parsing of PHP 8.4 property hooks #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of this, stricten the parsing of property names and use a narrower syntax but reuse AssignmentExpression for backwards compatibility of applications that originally used tolerant-php-parser's result of parseExpression. References: https://wiki.php.net/rfc/property-hooks and the linked php-src PR's zend_language_parser.y https://wiki.php.net/rfc/property-hooks#abbreviated_syntax https://wiki.php.net/rfc/property-hooks#interaction_with_constructor_property_promotion
dantleech
reviewed
Sep 3, 2024
| * @param PropertyHooks $parentNode | ||
| * @return PropertyHook | ||
| */ | ||
| private function parsePropertyHook($parentNode) { |
There was a problem hiding this comment.
we can safely add a real type hint here I think and a real return type?
dantleech
reviewed
Sep 3, 2024
| /** @var CompoundStatementNode|Expression|Token|null */ | ||
| public $body; | ||
| /** @var Token|null */ | ||
| public $semicolon; |
There was a problem hiding this comment.
not related to this PR but I guess we could consider bumping the minimum version to 8.0 or even 7.4? (nikic parser requires at least 7.4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this, stricten the parsing of property names and use a narrower syntax but reuse AssignmentExpression for backwards compatibility of applications that originally used tolerant-php-parser's result of parseExpression.
References:
https://wiki.php.net/rfc/property-hooks and the linked php-src PR's zend_language_parser.y
https://wiki.php.net/rfc/property-hooks#abbreviated_syntax https://wiki.php.net/rfc/property-hooks#interaction_with_constructor_property_promotion