Add EUDEM dataset #426
Merged
Add EUDEM dataset #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datasets
calebrob6
previously approved these changes
Feb 23, 2022
|
I ran through the dataset again and they are using the largest negative 32-bit floating point to mean 'no-data'. How should this be adressed? |
I think that's fine. When we merge tiles we take the larger value, so whether it's 0 or negative shouldn't make a difference. |
adamjstewart
requested changes
Feb 24, 2022
calebrob6
reviewed
Feb 25, 2022
calebrob6
previously approved these changes
Feb 25, 2022
|
Resolved merge conflicts |
adamjstewart
requested changes
Feb 26, 2022
adamjstewart
approved these changes
Feb 26, 2022
Merged
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* dataset file no test * add test and data.py * Update eudem.py * requested changes * Update torchgeo/datasets/eudem.py * Apply suggestions from code review * rST fix Co-authored-by: Caleb Robinson <calebrob6@gmail.com> Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #94 by adding another DEM dataset, the EUDEM, containing DEM for Europe. One can selectively download tiles after making an account.
Dataset features:
Dataset format:
Example:
