Fix float rounding issues #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datamodules
adamjstewart
commented
Aug 22, 2022
Comment on lines
+154
to
+155
| y1 = round((height - size) / 2) | ||
| x1 = round((width - size) / 2) |
There was a problem hiding this comment.
Pretty sure this is right. The previous logic can't really break, but it could lead to the centered image being shifted by up to 1 pixel. Now, it can be shifted by at most 0.5 pixels.
adamjstewart
commented
Aug 22, 2022
| val_length = int(len(dataset) * val_pct) | ||
| test_length = int(len(dataset) * test_pct) | ||
| val_length = round(len(dataset) * val_pct) | ||
| test_length = round(len(dataset) * test_pct) |
There was a problem hiding this comment.
Fixes #675 (comment)
adamjstewart
commented
Aug 22, 2022
| ) | ||
| masks = torch.tensor(masks).unsqueeze(0) | ||
| else: | ||
| masks = torch.zeros(size=(1, int(height), int(width))) | ||
| masks = torch.zeros(size=(1, round(height), round(width))) |
There was a problem hiding this comment.
Identical to #675
adamjstewart
commented
Aug 22, 2022
| @@ -67,7 +67,7 @@ def test_getitem(self, dataset: ETCI2021) -> None: | |||
| assert x["mask"].shape[0] == 1 | |||
|
|
|||
| def test_len(self, dataset: ETCI2021) -> None: | |||
| assert len(dataset) == 2 | |||
| assert len(dataset) == 3 | |||
There was a problem hiding this comment.
ETCI2021DataModule uses a 80/20 train/test split. Unfortunately, 80% of 2 is 2, so the test split was empty. Had to increase the size of the dataset by 1 to make the test split non-empty.
ashnair1
approved these changes
Aug 22, 2022
Modexus
pushed a commit
to Modexus/torchgeo
that referenced
this pull request
Sep 3, 2022
* Fix rounding bugs * Mypy fixes * Undo some changes * Undo some changes * mypy fixes * Fix tests * Increase size of ETCI2021 fake data * Undo model changes * line length fix
adamjstewart
added a commit
that referenced
this pull request
Sep 3, 2022
* Fix rounding bugs * Mypy fixes * Undo some changes * Undo some changes * mypy fixes * Fix tests * Increase size of ETCI2021 fake data * Undo model changes * line length fix
yichiac
pushed a commit
to yichiac/torchgeo
that referenced
this pull request
Apr 29, 2023
* Fix rounding bugs * Mypy fixes * Undo some changes * Undo some changes * mypy fixes * Fix tests * Increase size of ETCI2021 fake data * Undo model changes * line length fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, I checked all uses of
int(),round(),math.floor(),math.ceil(), and//in TorchGeo. Found a ton of redundant casts and what I believe to be a few bugs.Would be great to get a second set of eyes on the changes in this PR and the remaining uses that haven't changed. @TCherici @ashnair1 could I ask you to review this?
Fixes #679