Fix tt.dot to support integers #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhat-nguyen
reviewed
Aug 27, 2024
include/triton-shared/Conversion/TritonArithToLinalg/ConversionPatterns.hpp
Outdated
Show resolved
Hide resolved
nhat-nguyen
approved these changes
Aug 27, 2024
|
I have noticed the failure in lit tests, will follow-up with the fix |
|
Lit test should be good now |
|
I saw: "AttributeError: 'torch.dtype' object has no attribute 'startswith'", but it works for me, looks like I have a different version of pytorch, updated the code |
|
failed again on bfloa16, should be fixed now |
nhat-nguyen
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core tests are passing with current triton code, but this change:
triton-lang/triton#4573
should uncover more testcases, I checked that updates tests are also passing.