Add createBinding and setModuleDefault helpers #89

weswigham · 2020-02-14T21:16:01Z

This is the tslib PR for microsoft/TypeScript#35967

weswigham · 2020-02-24T23:43:35Z

cc @rbuckton do you have any feedback here, too?

tslib.js

rbuckton · 2020-02-24T23:46:35Z

tslib.js

@@ -273,4 +295,6 @@ var __classPrivateFieldSet;
    exporter("__importDefault", __importDefault);
    exporter("__classPrivateFieldGet", __classPrivateFieldGet);
    exporter("__classPrivateFieldSet", __classPrivateFieldSet);
+    exporter("__createBinding", __createBinding);
+    exporter("__setModuleDefault", __setModuleDefault)


I'm not sure this actually needs to be exposed, since no TypeScript code will emit tslib_1.__setModuleDefault (since its only used by __importStar).

tslib.es6.js

tslib.d.ts

… directly referenced

ExE-Boss

You forgot to remove __setModuleDefault from one more location.

ExE-Boss · 2020-02-25T11:29:17Z

tslib.js

@@ -35,6 +35,8 @@ var __importStar;
 var __importDefault;
 var __classPrivateFieldGet;
 var __classPrivateFieldSet;
+var __createBinding;
+var __setModuleDefault;


Suggested change

var __setModuleDefault;

ExE-Boss · 2020-02-25T11:30:08Z

tslib.js

+        o[k2] = m[k];
+    });
+
+    __setModuleDefault = Object.create ? (function(o, v) {


Suggested change

__setModuleDefault = Object.create ? (function(o, v) {

var __setModuleDefault = Object.create ? (function(o, v) {

ExE-Boss · 2020-02-25T11:38:18Z

tslib.d.ts

@@ -34,3 +34,4 @@ export declare function __importStar<T>(mod: T): T;
 export declare function __importDefault<T>(mod: T): T | { default: T };
 export declare function __classPrivateFieldGet<T extends object, V>(receiver: T, privateMap: WeakMap<T, V>): V;
 export declare function __classPrivateFieldSet<T extends object, V>(receiver: T, privateMap: WeakMap<T, V>, value: V): V;
+export declare function __createBinding(t: any, mod: any, k: string, k2?: string): void;


This should probably be:

Suggested change

export declare function __createBinding(t: any, mod: any, k: string, k2?: string): void;

export declare function __createBinding(t: object, mod: object, k: string, k2?: string): void;

or

Suggested change

export declare function __createBinding(t: any, mod: any, k: string, k2?: string): void;

export declare function __createBinding(t: object, mod: object, k: PropertyKey, k2?: PropertyKey): void;

ExE-Boss · 2020-02-25T13:22:04Z

tslib.es6.js

@@ -104,7 +104,7 @@ export function __generator(thisArg, body) {
 }

 export function __exportStar(m, exports) {
-    for (var p in m) if (!exports.hasOwnProperty(p)) exports[p] = m[p];
+    for (var p in m) if (!exports.hasOwnProperty(p)) __createBinding(exports, m, p);


exports.hasOwnProperty(p) won’t work in case exports has a null prototype or has overridden hasOwnProperty(…): microsoft/TypeScript#37013 and #92.

We should probably get in the habit of saving off intrinsics like this (i.e. var hasOwn = Object.prototype.hasOwnProperty and hasOwn.call(exports, p)), but we don't necessarily want to have to introduce a __hasOwn helper for that kind of case.

That said, its up to @weswigham if he wants to take on that change for tslib right now, since it's out of scope for this change.

That said, we do call Object.hasOwnProperty.call in __importStar below this.

weswigham · 2020-02-25T19:12:37Z

You forgot to remove __setModuleDefault from one more location.

Mmmm yes and no - the helper TS emits without importHelpers for __setModuleDefault checks for this.__setModuleDefault; so this makes sure that we use the tslib version if it's available. So it's not exported, per sey, as an intended entrypoint, but it is intentionally global in contexts where that makes sense, I guess?

rbuckton · 2020-02-26T01:58:06Z

the helper TS emits without importHelpers for __setModuleDefault checks for this.__setModuleDefault

We could always change that to the way that we define extendsStatics for the __extends helper. Either way, I'm not sure how important it is that we expose this one as a global.

weswigham · 2020-05-05T23:43:07Z

#99 now includes this, plus feedback~

weswigham added 2 commits February 14, 2020 13:15

Add __createBinding and __setModuleDefault helpers

5fd2a0e

Add __importStar changes

23d27f2

weswigham mentioned this pull request Feb 24, 2020

Use getters to define live export bindings refresh microsoft/TypeScript#35967

Merged

rbuckton requested changes Feb 24, 2020

View reviewed changes

weswigham added 2 commits February 24, 2020 15:47

Remove __setModuleDefault exports - keep it internal, since its never…

29e6ad3

… directly referenced

Remove parens

cf4ee1f

weswigham requested a review from rbuckton February 24, 2020 23:50

ExE-Boss suggested changes Feb 25, 2020

View reviewed changes

ExE-Boss reviewed Feb 25, 2020

View reviewed changes

weswigham mentioned this pull request May 5, 2020

Update helpers for TS 3.9 (Update __importStar, __exportStar, add __createBinding) #99

Merged

weswigham closed this May 5, 2020

weswigham deleted the create-binding branch May 6, 2020 00:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add createBinding and setModuleDefault helpers #89

Add createBinding and setModuleDefault helpers #89

weswigham commented Feb 14, 2020

weswigham commented Feb 24, 2020

rbuckton Feb 24, 2020 •

edited

Loading

ExE-Boss left a comment

ExE-Boss Feb 25, 2020

ExE-Boss Feb 25, 2020

ExE-Boss Feb 25, 2020 •

edited

Loading

ExE-Boss Feb 25, 2020

rbuckton Feb 26, 2020

rbuckton Feb 26, 2020

weswigham commented Feb 25, 2020

rbuckton commented Feb 26, 2020

weswigham commented May 5, 2020

	__setModuleDefault = Object.create ? (function(o, v) {
	var __setModuleDefault = Object.create ? (function(o, v) {

	export declare function __createBinding(t: any, mod: any, k: string, k2?: string): void;
	export declare function __createBinding(t: object, mod: object, k: string, k2?: string): void;

Add __createBinding and __setModuleDefault helpers #89

Add __createBinding and __setModuleDefault helpers #89

Conversation

weswigham commented Feb 14, 2020

weswigham commented Feb 24, 2020

rbuckton Feb 24, 2020 • edited Loading

Choose a reason for hiding this comment

ExE-Boss left a comment

Choose a reason for hiding this comment

ExE-Boss Feb 25, 2020

Choose a reason for hiding this comment

ExE-Boss Feb 25, 2020

Choose a reason for hiding this comment

ExE-Boss Feb 25, 2020 • edited Loading

Choose a reason for hiding this comment

ExE-Boss Feb 25, 2020

Choose a reason for hiding this comment

rbuckton Feb 26, 2020

Choose a reason for hiding this comment

rbuckton Feb 26, 2020

Choose a reason for hiding this comment

weswigham commented Feb 25, 2020

rbuckton commented Feb 26, 2020

weswigham commented May 5, 2020

Add createBinding and setModuleDefault helpers #89

Add createBinding and setModuleDefault helpers #89

rbuckton Feb 24, 2020 •

edited

Loading

ExE-Boss Feb 25, 2020 •

edited

Loading