Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to Node 16 #332

Merged
merged 1 commit into from
Jul 19, 2022
Merged

migrate to Node 16 #332

merged 1 commit into from
Jul 19, 2022

Conversation

AndreyIvanov42
Copy link
Contributor

@AndreyIvanov42 AndreyIvanov42 commented Jul 1, 2022 •
edited
Loading

Task description

Update the library to check compatibility with Node 16

Changelog

  • Added Node 16 to a pipeline

Testing

  • Changes have been tested on Linux, MacOS, Windows by unit-tests
  • Client has been tested manually on NodeTool task with Node 16 runtime
  • Enough test coverage for changes and current test coverage for the task doesn't look poor
  • I didn't find any breaking changes
  • There are no other concerns
  • I haven't discovered any new uncovered test/use cases

@AndreyIvanov42 AndreyIvanov42 added enhancement dependencies Pull requests that update a dependency file labels Jul 1, 2022
@AndreyIvanov42 AndreyIvanov42 requested a review from a team July 12, 2022 09:58
KonstantinTyukalov
KonstantinTyukalov reviewed Jul 12, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@AndreyIvanov42 AndreyIvanov42 force-pushed the users/v-andivanov/migrate-to-node-16 branch 2 times, most recently from 2d02844 to 5e93d7a Compare July 15, 2022 10:08
@AndreyIvanov42 AndreyIvanov42 force-pushed the users/v-andivanov/migrate-to-node-16 branch from 5e93d7a to f6843ce Compare July 15, 2022 10:36
@AndreyIvanov42 AndreyIvanov42 merged commit 7892e05 into master Jul 19, 2022
@AndreyIvanov42 AndreyIvanov42 deleted the users/v-andivanov/migrate-to-node-16 branch August 23, 2022 07:18
ajuanjojjj pushed a commit to ajuanjojjj/typed-rest-client that referenced this pull request Jul 5, 2024
@AndreyIvanov42 @ajuanjojjj
added Node 16 to pipeline (microsoft#332)
5d62809
@WontonSam WontonSam mentioned this pull request Aug 17, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Sep 7, 2024
Open
This was referenced Sep 9, 2024
Open
Open
Open
@WontonSam WontonSam mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirill-ivlev kirill-ivlev kirill-ivlev approved these changes

@wojgasior wojgasior wojgasior approved these changes

@DenisRumyantsev DenisRumyantsev DenisRumyantsev approved these changes

@KonstantinTyukalov KonstantinTyukalov KonstantinTyukalov approved these changes

@vmapetr vmapetr vmapetr approved these changes

@mmrazik mmrazik Awaiting requested review from mmrazik

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndreyIvanov42 @vmapetr @KonstantinTyukalov @DenisRumyantsev @wojgasior @kirill-ivlev