Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

fix: add expect to dependency whitelist #589

Merged
merged 1 commit into from
Mar 8, 2019
Merged

fix: add expect to dependency whitelist #589

merged 1 commit into from
Mar 8, 2019

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Mar 8, 2019

It's had types since jestjs/jest#7919, released as 24.3.0 earlier today

Needed for DefinitelyTyped/DefinitelyTyped#33705

@@ -40,6 +40,7 @@ egg
electron
eventemitter2
eventemitter3
expect
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bunch of other jest packages also has types now, but I guess this list should only contain the packages we know we need and not everything that's theoretically possible?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, basically.

@sandersn sandersn merged commit 6b2b744 into microsoft:master Mar 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants