Add unit test to mainAsync #151
Conversation
|
Seems like the tests fail; you're mocking the FS but also using the FS. |
|
Fixed. I didn't occur to me to run the rest of the tests, I think it will work now. |
|
Seems like I was wrong. |
| // @ts-ignore | ||
| Symbol.asyncDispose ??= Symbol("Symbol.asyncDispose"); |
There was a problem hiding this comment.
What version of node are you on? This should be present.
There was a problem hiding this comment.
Hm, was this crashing locally or in CI?
(It passed for me previously when I introduced this code, anyway....)
There was a problem hiding this comment.
Locally, I assume it would crash on CI but I can give it a try without it
There was a problem hiding this comment.
Wow, it does fail. That doesn't make any sense at all...
There was a problem hiding this comment.
It fails on CI as well
There was a problem hiding this comment.
Oh, this is because jest makes an entirely different environment that's missing these, even though the system has it: jestjs/jest#14874
I guess we can leave it in, though we could probably also just swap jest out for vitest.
There was a problem hiding this comment.
I put it back then. We can track migrating to vitest on issue #153
Adds a simple unit test for the
mainAsyncfunction.Mostly mocks the dependencies on the file system and utility modules. This allows to easily test the
mainAsyncwith a snapshot during local development.Please note that I was not able to accurately verify that this is the expected result. I appreciate if any reviewer put special emphasis on the accuracy of the output.