Remove groupedBy from InputParameter (#3617)

Removes the `groupedBy` parameter from `InputParameter` as it's not supported by TSP yet. fixes : Azure/autorest.csharp#4779
microsoft · Jun 19, 2024 · f566053 · f566053
1 parent 04a389f
commit f566053
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/...client-csharp/generator/Microsoft.Generator.CSharp.Input/src/InputTypes/InputParameter.cs b/...client-csharp/generator/Microsoft.Generator.CSharp.Input/src/InputTypes/InputParameter.cs
@@ -12,7 +12,6 @@ public InputParameter(
             InputType type,
             RequestLocation location,
             InputConstant? defaultValue,
-            InputParameter? groupedBy,
             InputOperationParameterKind kind,
             bool isRequired,
             bool isApiVersion,
@@ -30,7 +29,6 @@ public InputParameter(
             Type = type;
             Location = location;
             DefaultValue = defaultValue;
-            GroupedBy = groupedBy;
             Kind = kind;
             IsRequired = isRequired;
             IsApiVersion = isApiVersion;
@@ -49,7 +47,6 @@ public InputParameter(
         public InputType Type { get; }
         public RequestLocation Location { get; }
         public InputConstant? DefaultValue { get; }
-        public InputParameter? GroupedBy { get; }
         public InputOperationParameterKind Kind { get; }
         public bool IsRequired { get; }
         public bool IsApiVersion { get; }

diff --git a/...ft.Generator.CSharp.Input/src/InputTypes/Serialization/TypeSpecInputParameterConverter.cs b/...ft.Generator.CSharp.Input/src/InputTypes/Serialization/TypeSpecInputParameterConverter.cs
@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
+// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
 using System;
@@ -33,7 +33,6 @@ public static InputParameter CreateInputParameter(ref Utf8JsonReader reader, str
             InputType? parameterType = null;
             string? location = null;
             InputConstant? defaultValue = null;
-            InputParameter? groupBy = null;
             string? kind = null;
             bool isRequired = false;
             bool isApiVersion = false;
@@ -53,7 +52,6 @@ public static InputParameter CreateInputParameter(ref Utf8JsonReader reader, str
                     || reader.TryReadWithConverter(nameof(InputParameter.Type), options, ref parameterType)
                     || reader.TryReadString(nameof(InputParameter.Location), ref location)
                     || reader.TryReadWithConverter(nameof(InputParameter.DefaultValue), options, ref defaultValue)
-                    || reader.TryReadWithConverter(nameof(InputParameter.GroupedBy), options, ref groupBy)
                     || reader.TryReadString(nameof(InputParameter.Kind), ref kind)
                     || reader.TryReadBoolean(nameof(InputParameter.IsRequired), ref isRequired)
                     || reader.TryReadBoolean(nameof(InputParameter.IsApiVersion), ref isApiVersion)
@@ -94,7 +92,6 @@ public static InputParameter CreateInputParameter(ref Utf8JsonReader reader, str
                 type: parameterType,
                 location: requestLocation,
                 defaultValue: defaultValue,
-                groupedBy: groupBy,
                 kind: parameterKind,
                 isRequired: isRequired,
                 isApiVersion: isApiVersion,

diff --git a/...tp-client-csharp/generator/Microsoft.Generator.CSharp/test/CSharpMethodCollectionTests.cs b/...tp-client-csharp/generator/Microsoft.Generator.CSharp/test/CSharpMethodCollectionTests.cs
@@ -76,7 +76,7 @@ public static IEnumerable<TestCaseData> DefaultCSharpMethodCollectionTestCases
                     description: string.Empty,
                     accessibility: null,
                     parameters: [
-                        new InputParameter("message", "message", "The message to create.", new InputPrimitiveType(InputPrimitiveTypeKind.Boolean), RequestLocation.Body, null, null, InputOperationParameterKind.Method, true, false, false, false, false, false, false, null, null)
+                        new InputParameter("message", "message", "The message to create.", new InputPrimitiveType(InputPrimitiveTypeKind.Boolean), RequestLocation.Body, null, InputOperationParameterKind.Method, true, false, false, false, false, false, false, null, null)
                         ],
                     responses: Array.Empty<OperationResponse>(),
                     httpMethod: "GET",