Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce the abstraction for credentials (key credential, oauth credential) #4410

Closed
ArcturusZhang opened this issue Sep 12, 2024 · 1 comment · Fixed by #5231
Closed

Introduce the abstraction for credentials (key credential, oauth credential) #4410

ArcturusZhang opened this issue Sep 12, 2024 · 1 comment · Fixed by #5231
Assignees
@ArcturusZhang
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@ArcturusZhang
Copy link
Member

ArcturusZhang commented Sep 12, 2024 •
edited
Loading

Since we might be needing to call APIs on credentials, and there are different types between unbranded libraries and azure libraries, we might need to introduce an abstraction for those credential types.

We could defer this work until the work on azure plugin could not be done until we have the abstraction. Before that, maybe a simple type is enough
@ArcturusZhang ArcturusZhang added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Sep 12, 2024
@JoshLove-msft
Copy link
Contributor

@live1206, do you have an idea of when you will tackle this? Feel free to add the iteration to the issue.

@live1206 live1206 assigned ArcturusZhang and unassigned live1206 Nov 25, 2024
@ArcturusZhang ArcturusZhang mentioned this issue Nov 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 16, 2024
@ArcturusZhang
introduce the abstraction for tokencredential type and keycredential …
3bd6a87 
…type (#5231)

Fixes #5235
Fixes #4410

The ClientProviderTests class contains both general client provider
features (such as service operations, query parameters, api-versions)
and auth specific features.
My PR is trying to separate them - therefore some test cases are moved
to a new class.
archerzz pushed a commit to archerzz/typespec that referenced this issue Dec 17, 2024
@ArcturusZhang
introduce the abstraction for tokencredential type and keycredential …
9454da5 
…type (microsoft#5231)

Fixes microsoft#5235
Fixes microsoft#4410

The ClientProviderTests class contains both general client provider
features (such as service operations, query parameters, api-versions)
and auth specific features.
My PR is trying to separate them - therefore some test cases are moved
to a new class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArcturusZhang ArcturusZhang

Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

introduce the abstraction for tokencredential type and keycredential type ArcturusZhang/typespec
3 participants
@live1206 @ArcturusZhang @JoshLove-msft