Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove groupedBy from InputParameter #3617

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Remove groupedBy from InputParameter #3617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...client-csharp/generator/Microsoft.Generator.CSharp.Input/src/InputTypes/InputParameter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ public InputParameter(
InputType type,
RequestLocation location,
InputConstant? defaultValue,
InputParameter? groupedBy,
InputOperationParameterKind kind,
bool isRequired,
bool isApiVersion,
Expand All @@ -30,7 +29,6 @@ public InputParameter(
Type = type;
Location = location;
DefaultValue = defaultValue;
GroupedBy = groupedBy;
Kind = kind;
IsRequired = isRequired;
IsApiVersion = isApiVersion;
Expand All @@ -49,7 +47,6 @@ public InputParameter(
public InputType Type { get; }
public RequestLocation Location { get; }
public InputConstant? DefaultValue { get; }
public InputParameter? GroupedBy { get; }
public InputOperationParameterKind Kind { get; }
public bool IsRequired { get; }
public bool IsApiVersion { get; }
Expand Down
5 changes: 1 addition & 4 deletions ...ft.Generator.CSharp.Input/src/InputTypes/Serialization/TypeSpecInputParameterConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

using System;
Expand Down Expand Up @@ -33,7 +33,6 @@ public static InputParameter CreateInputParameter(ref Utf8JsonReader reader, str
InputType? parameterType = null;
string? location = null;
InputConstant? defaultValue = null;
InputParameter? groupBy = null;
string? kind = null;
bool isRequired = false;
bool isApiVersion = false;
Expand All @@ -53,7 +52,6 @@ public static InputParameter CreateInputParameter(ref Utf8JsonReader reader, str
|| reader.TryReadWithConverter(nameof(InputParameter.Type), options, ref parameterType)
|| reader.TryReadString(nameof(InputParameter.Location), ref location)
|| reader.TryReadWithConverter(nameof(InputParameter.DefaultValue), options, ref defaultValue)
|| reader.TryReadWithConverter(nameof(InputParameter.GroupedBy), options, ref groupBy)
|| reader.TryReadString(nameof(InputParameter.Kind), ref kind)
|| reader.TryReadBoolean(nameof(InputParameter.IsRequired), ref isRequired)
|| reader.TryReadBoolean(nameof(InputParameter.IsApiVersion), ref isApiVersion)
Expand Down Expand Up @@ -94,7 +92,6 @@ public static InputParameter CreateInputParameter(ref Utf8JsonReader reader, str
type: parameterType,
location: requestLocation,
defaultValue: defaultValue,
groupedBy: groupBy,
kind: parameterKind,
isRequired: isRequired,
isApiVersion: isApiVersion,
Expand Down
2 changes: 1 addition & 1 deletion ...tp-client-csharp/generator/Microsoft.Generator.CSharp/test/CSharpMethodCollectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public static IEnumerable<TestCaseData> DefaultCSharpMethodCollectionTestCases
description: string.Empty,
accessibility: null,
parameters: [
new InputParameter("message", "message", "The message to create.", new InputPrimitiveType(InputPrimitiveTypeKind.Boolean), RequestLocation.Body, null, null, InputOperationParameterKind.Method, true, false, false, false, false, false, false, null, null)
new InputParameter("message", "message", "The message to create.", new InputPrimitiveType(InputPrimitiveTypeKind.Boolean), RequestLocation.Body, null, InputOperationParameterKind.Method, true, false, false, false, false, false, false, null, null)
],
responses: Array.Empty<OperationResponse>(),
httpMethod: "GET",
Expand Down
Loading