Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine client pipeline abstraction #5044

Merged
merged 10 commits into from
Nov 12, 2024

Conversation

live1206
Copy link
Contributor

@live1206 live1206 commented Nov 11, 2024

  • Make ClientPipelineApi.ProcessMessage(Async) abstract directly
  • Remove ClientPipelineApi.Send(Async), it is covered in above item
  • Remove HttpMessageApi.ExtractResponse, it is covered in the first item

Corresponding change in Azure plugin: Azure/azure-sdk-for-net#47049

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Nov 11, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Generator.CSharp.ClientModel

@live1206 live1206 marked this pull request as ready for review November 11, 2024 06:19
@ArcturusZhang
Copy link
Member

looks like we are on a path of "abstraction by procedure" instead of "abstraction by API".
I like the new way which reduces the complexity and makes the system easy to use, the most important, it could lower the bias on this topic.

@live1206 live1206 added this pull request to the merge queue Nov 12, 2024
Merged via the queue into microsoft:main with commit e10bab8 Nov 12, 2024
21 checks passed
@live1206 live1206 deleted the refine-client-pipeline-abstraction branch November 12, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants