Deduplicate even more things #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup to microsoft#1355 Also renames the JSON documents that talk to tests and to artifacts to follow the convention used elsewhere.
ras0219-msft
approved these changes
Mar 5, 2024
src/vcpkg/spdx.cpp
Outdated
| rel.insert("spdxElementId", "SPDXRef-port"); | ||
| rel.insert("relationshipType", "GENERATES"); | ||
| rel.insert("relatedSpdxElement", "SPDXRef-binary"); | ||
| rel.insert(JsonIdSpdxCapitalElementCapitalId, JsonIdMixedCaseSPDXRefPort); |
There was a problem hiding this comment.
Suggestion: the SPDXRef values should be a different semantic category than JsonId. For example:
SPDXRefDocument
SPDXRefPort
SPDXRefBinary
I think a lot of the SPDX stuff may form its own semantic category as a 'subset' of JSON: SPDXGenerates, SPDXNoAssertion, etc.
(as-is is also ok)
There was a problem hiding this comment.
I separated SPDX values that otherwise needed a lot of 'MixedCase' / 'AllCaps' / 'Underscore' / etc. into their own group.
ras0219-msft
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1355
Also renames the JSON documents that talk to tests and to artifacts to follow the convention used elsewhere.