Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloads: Improve error message url is invalid #1411

Merged
merged 5 commits into from
Jul 6, 2024
Merged

Downloads: Improve error message url is invalid #1411

merged 5 commits into from
Jul 6, 2024

Conversation

autoantwort
Copy link
Contributor

BillyONeal
BillyONeal reviewed May 28, 2024
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test? I think this one should be unit testable...

src/vcpkg/base/downloads.cpp Outdated Show resolved Hide resolved
autoantwort and others added 2 commits June 26, 2024 15:55
@autoantwort @BillyONeal
Apply suggestion
4f1f0ed 
Co-authored-by: Billy O'Neal <bion@microsoft.com>
@autoantwort
Format
4b11b09
@autoantwort
Copy link
Contributor Author

Can you add a test? I think this one should be unit testable...

There are tests for split_uri_view, but I haven't changed that function. And this functions calls curl, so I don't think that this function (try_download_file) is unit testable.

@BillyONeal
Copy link
Member

Ah, I see, when I first read this I read the substr(2) as new parsing code that should be tested but I see now you only moved it down from above.

@BillyONeal BillyONeal enabled auto-merge (squash) July 6, 2024 02:07
@BillyONeal BillyONeal merged commit 7e0d199 into microsoft:main Jul 6, 2024
5 checks passed
@autoantwort autoantwort deleted the feature/better-error-message branch July 10, 2024 11:49
@BillyONeal BillyONeal mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

internal error: D:\a\_work\1\s\src\vcpkg\base\downloads.cpp(767): Value was null
2 participants
@autoantwort @BillyONeal