Fix grammar in HashPortManyFiles warning message #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
reviewed
Jul 30, 2024
| @@ -1387,7 +1387,7 @@ DECLARE_MESSAGE(HashFileFailureToRead, | |||
| DECLARE_MESSAGE(HashPortManyFiles, | |||
| (msg::package_name, msg::count), | |||
| "", | |||
| "The {package_name} contains {count} files. Hashing these contents may take a long time when " | |||
| "The port '{package_name}' contains {count} files. Hashing these contents may take a long time when " | |||
There was a problem hiding this comment.
Suggested change
| "The port '{package_name}' contains {count} files. Hashing these contents may take a long time when " | |
| "{package_name} contains {count} files. Hashing these contents may take a long time when " |
Dropping "the <kind> '<name>'" was an intentional change but leaving 'the' there was not 😅
Thanks for the report!
There was a problem hiding this comment.
166ecc1. Thanks!
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous message said
The zlib contains 42 files. Now saysThe port 'zlib' contains 42 files