-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[upgrade] Don't crash on non-installed ports #1473
Conversation
Not sure, just wondering: Would it be useful to issue a warning, then install? (the goal would be a command that ensures you have the most current version, no matter if an old is installed or not) |
@GitMensch I believe |
Ah, nope :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I like this resolution because it's undoing what appears to be a very explicit attempt to emit all possible errors rather than stopping at the first error. Making a competing solution shortly...
I think that's a different issue.
I restored emitting all errors. |
Thanks! |
Removes the hack added in microsoft#1477 Tests the condition fixed by microsoft#1473
Fixes microsoft/vcpkg#21117
output before:
output after: