Support Azure universal packages as a binary caching provider #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
reviewed
Sep 17, 2024
BillyONeal
reviewed
Sep 23, 2024
| { | ||
| size_t count_stored = 0; | ||
| auto ref = make_feedref(request, ""); | ||
| std::string package_description = "Cached package for " + ref.id; |
There was a problem hiding this comment.
I think it would be a good idea to have this be in FeedReference so that it can be tested rather than made up here.
There was a problem hiding this comment.
Good idea. I will make that change in another PR after this PR is merged.
BillyONeal
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Only nitpicks remain. This approval is contingent on the room saying the spelling/behavior is OK and either:
- testing that the version of
azyou look for actually supports the feature you're trying to use, or - setting the minimum version we're looking for to what you actually tested
vicroms
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Azure CLI, specifically the
az artifacts universal downloadandaz artifacts universal publishcommands, which are APIs needed to fetch and store packages.In order to authenticate, you will need to login to the Azure CLI before running vcpkg.