Fix all download failures claiming that the download was disabled by x-block-origin.

[JavierMatosD]

The tool currently falsely claims that "Missing [package] and downloads are blocked by x-block-origin"

To repro:

.\vcpkg.exe x-download out.txt --skip-sha512 --url=
https://nonexistent.com/

output:

~/dev/vcpkg-tool % out/build/macos-ci/vcpkg x-download out.txt --skip-sha512 --url=
https://nonexistent.com
error: Missing out.txt and downloads are blocked by x-block-origin.
error: : curl failed to download with exit code 2
curl: (2) no URL specified
curl: try 'curl --help' or 'curl --manual' for more information

Expected:

~/dev/vcpkg-tool % out/build/macos-ci/vcpkg x-download out.txt --skip-sha512 --url=
https://nonexistent.com
error: : curl failed to download with exit code 2
curl: (2) no URL specified
curl: try 'curl --help' or 'curl --manual' for more information

[BillyONeal]

This output is still broken; we aren't downloading from the destination file name:

Can you fix this and show that you've smoke tested at least the following and seen reasonable results? (I understand that writing automated tests for this can be hard because it depends on what is up but if you've got ideas on testing it that would be good...)

[JavierMatosD]

Initial smoke tests

File exists

Expect: Message that file exists and matches the SHA

Note

BUG: Currently it prints "Download [pkg]". This is bogus

File does not exist

azurl (no), x-block-origin (no), asset-cache (n/a), download (fail)
Expected: Download failure message, nothing about asset caching

azurl (no), x-block-origin (no), asset-cache (n/a), download (sha-mismatch)
Expected: Download message with "you might need to configure a proxy" and expected/actual sha

Note

Missing the "you might need to configure a proxy"

azurl (no), x-block-origin (no), asset-cache (n/a), download (succeed)
Expected: Download success message, nothing about asset caching

Note

BUG: Currently prints "Downloading [pkg]". Should be download success message.

azurl (no), x-block-origin (yes), asset-cache (n/a), download (n/a)
Expected: Download failure message, nothing about asset caching, x-block-origin complaint

---

azurl (yes), x-block-origin (no), asset-cache (miss), download (fail)
Expected: Download failure message, asset cache named, nothing about x-block-origin

Note

The curl messaging is confusing?

azurl (yes), x-block-origin (no), asset-cache (hit), download (n/a)
Expected: Download success message, asset cache named, nothing about x-block-origin

azurl (yes), x-block-origin (no), asset-cache (miss), download (sha-mismatch)
Expected: Download message with "you might need to configure a proxy" and expected/actual sha

Note

Missing the "you might need to configure a proxy"

azurl (yes), x-block-origin (no), asset-cache (miss), download (succeed)
Expected: Download success message, asset cache upload, nothing about x-block-origin

azurl (yes), x-block-origin (yes), asset-cache (miss), download (n/a)
Expected: Download failure message, which asset cache was tried, x-block-origin complaint

Note

This prints the x-block-origin complaint two separate times

azurl (yes), x-block-origin (yes), asset-cache (hit), download (n/a)
Expected: Download success message, asset cache named, nothing about x-block-origin

[JavierMatosD]

Note: No "you might need to configure a proxy". I could add back in, but it feels like a potentially misleading message.

[BillyONeal]

Considering it was in the CMake block we are removing I think it should be there.

[JavierMatosD]

Actually, we aren't removing the "you might need to configure a proxy" message from cmake world. https://github.com/microsoft/vcpkg/pull/40945/files#diff-95f7d8e8b25d1928ee2738036384adec841ddd80c51a526f45e9df167fea5b37L31

https://github.com/microsoft/vcpkg/pull/40945/files#diff-95f7d8e8b25d1928ee2738036384adec841ddd80c51a526f45e9df167fea5b37L270

[BillyONeal]

Closed and reopened to kick CLABot

[BillyONeal]

Only nitpicks here, you can ignore them if you want.

I would really like to see the proxy message return given that we're removing it from CMake land.

[BillyONeal]

Considering it was in the CMake block we are removing I think it should be there.

[BillyONeal]

I'm happy with this if the newline replacements that Run-VcpkgAndCaptureOutput already does are removed.

I still believe that it's a bug that we don't emit the proxy message which means CMake is still emitting a separate, different, download failure message, as that might be complaining about proxy when the actual reason is x-block-origin, but this PR is an improvement over the status quo.

[JavierMatosD]

Downloading example3.html
Failed to download example3.html.
If you are using a proxy, please ensure your proxy settings are correct.
Possible causes are:
1. You are actually using an HTTP proxy, but setting HTTPS_PROXY variable to `https//address:port`.
This is not correct, because `https://` prefix claims the proxy is an HTTPS proxy, while your proxy (v2ray, shadowsocksr, etc...) is an HTTP proxy.
Try setting `http://address:port` to both HTTP_PROXY and HTTPS_PROXY instead.
2. If you are using Windows, vcpkg will automatically use your Windows IE Proxy Settings set by your proxy software. See, https://github.com/microsoft/vcpkg-tool/pull/77
The value set by your proxy might be wrong, or have same `https://` prefix issue.
3. Your proxy's remote server is our of service.
If you've tried directly download the link, and believe this is not a temporay download server failure, please submit an issue at https://github.com/Microsoft/vcpkg/issues
to report this upstream download server failure.
error: https://localhost:1234/foobar.html: curl failed to download with exit code 7
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

curl: (7) Failed to connect to localhost port 1234 after 0 ms: Couldn't connect to server