Remove cmd_execute_and_stream_data() returned debug message.

[BillyONeal]

We have seen no reports of broken subprocess output handling, and this message is very spammy. Given that we still have a few messages that direct end users at --debug that seems reason enough to remove spammy messages like this.

[ashlhud]

This would have been helpful to disambiguate some errors we were seeing with our asset cache tool. +1

[autoantwort]

I am against removing this debug statement. I find it helpful when analyzing why things don't work as expected. But I would prefer a human readable time format :D

[BillyONeal]

I am against removing this debug statement. I find it helpful when analyzing why things don't work as expected. But I would prefer a human readable time format :D

I think any such cases should be replaced by adding EchoInDebug to the right places rather than discussing return values of ReadFile

[autoantwort]

At least on Unix it prints the exit code of the command that failed. And EchoInDebug would be spammy I guess 😅

[BillyONeal]

At least on Unix it prints the exit code of the command that failed.

No, it prints the errno of the read call. This 'exit code' is not the child process' exit code.

[BillyONeal]

Wait, this is the wrong one...

[BillyONeal]

This is not the spam I thought it was; perhaps I already removed it a while ago. Thanks to @autoantwort for pointing this out.