[vcpkg] Add timeout to curl download from FTP and HTTP #1552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix microsoft/vcpkg#42394
The
put_file
function lacked timeout parameters forcurl
commands, leading to potential hangs if the server was unresponsive. This update improves the robustness by adding--max-time
and--connect-timeout
.Added
--max-time (60 seconds)
and--connect-timeout (10 seconds)
to curl commands.Used constants for timeout values for maintainability.