Don't use non functional cmake versions #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoantwort
commented
Jan 5, 2025
src/vcpkg/tools.cpp
Outdated
| @@ -765,6 +773,7 @@ namespace vcpkg | |||
| for (auto&& candidate : candidates) | |||
| { | |||
| if (!fs.exists(candidate, IgnoreErrors{})) continue; | |||
| if (!tool_provider.is_acceptable(candidate)) continue; | |||
There was a problem hiding this comment.
The path check is cheaper then running the tool, therefore i moved the check upwards.
There was a problem hiding this comment.
This improves CMake but regresses Python detection by trying to create virtual environments for versions we don't want anyway. Introduce a new virtual for CMake to use here instead?
There was a problem hiding this comment.
I have created the new function cheap_is_acceptable. If you have a better name, I will take it 😆
autoantwort
force-pushed
the
feature/no-broken-cmake
branch
from
4895649 to
a1bb947
Compare
dg0yt
reviewed
Jan 5, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents microsoft/vcpkg#43063
See microsoft/vcpkg#43063 (comment)