Only consult applocal userconfig if metrics are enabled #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vicroms
approved these changes
Sep 1, 2021
BillyONeal
reviewed
Sep 1, 2021
…ev/roschuma/userconfig
BillyONeal
approved these changes
Nov 5, 2021
|
I am happy that my comments were addressed here and think this is ready to land as soon as builds and tests pass. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ras0219-msft
force-pushed
the
dev/roschuma/userconfig
branch
2 times, most recently
from
faf4413
to
d4442f9
Compare
ras0219-msft
force-pushed
the
dev/roschuma/userconfig
branch
from
d4442f9
to
aa40a41
Compare
|
Many recursive locking bugs later, success! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If metrics are not enabled, we do not need to read and write the user config file.